refactor: remove the widen type #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-karlsson
requested review from
Billlynch,
fabriziodemaria,
mfranberg,
vahidlazio,
nicklasl and
nickybondarenko
as code owners
nicklasl
approved these changes
Aug 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There, I just made a Pull Request!
This PR removes the "Widen" type which was there as a fix for return types being referred too narrowly. For instance the return value of
getFlagshould be of the same type as the default value arg. But if you called getFlag with a3as the default value the inferred return type would be3instead ofnumber. The Widen type caused some unnecessary complexity though, and now the problem is fixed with overloads instead.✔️ Checklist